FishEye: history quartz/trunk/src/java/org/quartz/simpl/PropertySettingJobFactory.java

426 annotated / raw | Diffs: previous, other | Lines: 288 ( +8, -7 )

Created: 2006-03-20 15:40:36 -0600 (2 years 9 months ago) | Author: jrosenberg | Changeset: 426

Issue number: QUARTZ-374
Fixed main Quartz src to comply with checkstyle

Branch point for: quartz_1-6

Tags: quartz_1-6-0-alpha

Properties

svn:eol-style = native

413 annotated / raw | Diffs: previous, other | Lines: 287 ( +2, -5 )

Created: 2006-03-16 11:03:27 -0600 (2 years 9 months ago) | Author: jrosenberg | Changeset: 413

Issue number: QUARTZ-369
Cleaned up the logging to be consistent, following these rules:
1. Do not cache the log statically, to avoid potential redeployment issues.
2. Where appropriate, do cache the log in a private final member. By appropriate, I mean if the class always uses the log during normal execution, or if very few of the object are ever created.
For example, AttributeRestoringConnectionWrapper does not cache the log because it only uses the log for warning cases, and an instance is created per connection.
private final Log log = LogFactory.getLog(getClass());
3. Expose the log through a protected non-static getLog() method that can be then used by any subclass (existing public methods are left public for backwards compatibility, though in a few cases a static getLog() method was changed to be non-static which would break backwards compatibility if the methods were being used, though it seems extremely unlikely they would be.)
4. Pass getClass() to LogFactory.getLog() rather than ClassName.class, so that subclasses always get the correct category name
5. One exception to these rules is UserTransactionHelper which is an all static class, and so has a static getLog method, does not cache the log, and must use the UserTransactionHelper.class category.
6. Also did a quick run through to make sure any debug messages that are building strings dynamically are protected by isDebugEnabled()

Properties

svn:eol-style = native

388 annotated / raw | Diffs: previous, other | Lines: 290 ( +117, -137 )

Created: 2006-03-07 15:32:32 -0600 (2 years 10 months ago) | Author: jrosenberg | Changeset: 388

Issue number: QUARTZ-360
Minor cleanup and enhancements for the property setting around primatives and null values

Properties

svn:eol-style = native

387 annotated / raw | Diffs: previous, other | Lines: 310 ( +1, -1 )

Created: 2006-03-07 13:57:57 -0600 (2 years 10 months ago) | Author: jrosenberg | Changeset: 387

Issue number: QUARTZ-359
Remove unnecessary map key lookups by using entrySet() (Fixed cut and paste error where was getting key instead of value)

Properties

svn:eol-style = native

386 annotated / raw | Diffs: previous, other | Lines: 310 ( +9, -4 )

Created: 2006-03-07 12:38:37 -0600 (2 years 10 months ago) | Author: jrosenberg | Changeset: 386

Issue number: QUARTZ-359
Remove unnecessary map key lookups by using entrySet() (or in once case of StdJDBCDelegate.convertFromProperty() just passing the Properties to add to the HashMap constructor)

Properties

svn:eol-style = native

365 annotated / raw | Diffs: previous, other | Lines: 305 ( +1, -1 )

Created: 2006-03-03 11:34:14 -0600 (2 years 10 months ago) | Author: jrosenberg | Changeset: 365

Issue number: QUARTZ-346
Cleaned up javadoc warnings

Properties

svn:eol-style = native

228 annotated / raw | Diffs: previous, other | Lines: 305 ( +1, -1 )

Created: 2005-08-22 22:53:14 -0500 (3 years 4 months ago) | Author: jhouse | Changeset: 228

refactored JobExecutionContext.getJobDataMap() to be getMergedJobDataMap()

CVS: ----------------------------------------------------------------------
CVS: Issue number:
CVS:   If this change addresses one or more issues,
CVS:   then enter the issue number(s) here.
CVS: Obtained from:
CVS:   If this change has been taken from another system,
CVS:   then name the system in this line, otherwise delete it.
CVS: Submitted by:
CVS:   If this code has been contributed to the project by someone else; i.e.,
CVS:   they sent us a patch or a set of diffs, then include their name/email
CVS:   address here. If this is your work then delete this line.
CVS: Reviewed by:
CVS:   If we are doing pre-commit code reviews and someone else has
CVS:   reviewed your changes, include their name(s) here.
CVS:   If you have not had it reviewed then delete this line.

Branch point for: b_quartz_1-5-x

Tags: v1_5_0 quartz_1-5-1 quartz_1-5-2

Properties

svn:eol-style = native

189 annotated / raw | Diffs: previous, other | Lines: 305 ( +2, -1 )

Created: 2005-08-06 11:44:40 -0500 (3 years 5 months ago) | Author: jhouse | Changeset: 189

Issue number: QUARTZ-231
Obtained from:
Submitted by:
Reviewed by:
CVS: ----------------------------------------------------------------------
CVS: Issue number:
CVS:   If this change addresses one or more issues,
CVS:   then enter the issue number(s) here.
CVS: Obtained from:
CVS:   If this change has been taken from another system,
CVS:   then name the system in this line, otherwise delete it.
CVS: Submitted by:
CVS:   If this code has been contributed to the project by someone else; i.e.,
CVS:   they sent us a patch or a set of diffs, then include their name/email
CVS:   address here. If this is your work then delete this line.
CVS: Reviewed by:
CVS:   If we are doing pre-commit code reviews and someone else has
CVS:   reviewed your changes, include their name(s) here.
CVS:   If you have not had it reviewed then delete this line.

Tags: quartz_1_5_0_rc1

Properties

svn:eol-style = native

169 new annotated / raw | Lines: 304 ( +304, -0 )

Created: 2005-07-16 23:20:18 -0500 (3 years 5 months ago) | Author: jhouse | Changeset: 169

Issue number: QUARTZ-221
Obtained from: jhouse
Submitted by: jhouse
Reviewed by:   jhouse
CVS: ----------------------------------------------------------------------
CVS: Issue number:
CVS:   If this change addresses one or more issues,
CVS:   then enter the issue number(s) here.
CVS: Obtained from:
CVS:   If this change has been taken from another system,
CVS:   then name the system in this line, otherwise delete it.
CVS: Submitted by:
CVS:   If this code has been contributed to the project by someone else; i.e.,
CVS:   they sent us a patch or a set of diffs, then include their name/email
CVS:   address here. If this is your work then delete this line.
CVS: Reviewed by:
CVS:   If we are doing pre-commit code reviews and someone else has
CVS:   reviewed your changes, include their name(s) here.
CVS:   If you have not had it reviewed then delete this line.

Properties

svn:eol-style = native

FishEye

View detailed chart Line History

View Mode

Show Arbitrary Diff

Watches and RSS

History

latest revision trunk